add removceDuplicate helper method to VoiceCommand #1665
Merged
+31
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1664
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
Added unit test for lists with duplicate strings
Core Tests
Test sending a list of voiceCommands where there are duplicate strings
You should now only see one voice command for each unique string you set
Core version / branch / commit hash / module tested against: Manticore
HMI name / version / branch / commit hash / module tested against: Manticore
Summary
This PR adds a helper function to VoiceCommand.java that will remove any duplicate strings when setVoiceCommands gets called. This PR adds the appropriate unit tests
CLA