Skip to content

Conversation

@JulianKast
Copy link
Contributor

@JulianKast JulianKast commented Apr 28, 2021

Fixes #1669

This PR is {ready] for review.

Risk

This PR makes [no] API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android, Java SE, and Java EE

Summary

ReadME updates for hotfix 5.1.1

CLA

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #1668 (8137039) into release/5.1.1_RC (9eef69d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             release/5.1.1_RC    #1668   +/-   ##
===================================================
  Coverage               53.94%   53.94%           
- Complexity               5304     5307    +3     
===================================================
  Files                     555      555           
  Lines                   24561    24561           
  Branches                 3101     3101           
===================================================
  Hits                    13250    13250           
  Misses                  10160    10160           
  Partials                 1151     1151           
Impacted Files Coverage Δ Complexity Δ
...agers/screen/menu/VoiceCommandUpdateOperation.java 76.85% <0.00%> (-1.86%) 16.00% <0.00%> (-1.00%)
...rtdevicelink/streaming/video/SdlRemoteDisplay.java 50.00% <0.00%> (-1.22%) 5.00% <0.00%> (ø%)
...ink/managers/screen/BaseTextAndGraphicManager.java 64.16% <0.00%> (+0.41%) 52.00% <0.00%> (+2.00%)
...nk/managers/audio/AudioDecoderCompatOperation.java 79.54% <0.00%> (+4.54%) 10.00% <0.00%> (+1.00%)

@JulianKast JulianKast changed the base branch from master to release/5.1.1_RC April 28, 2021 14:04
Copy link
Contributor

@RHenigan RHenigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that 5.0 is on mavenCentral I think we should update the dependency lines to use 5.+ instead of a specific version and I think the badges should still read Download Android, or Downlaod JavaSE, etc. instead of Maven Central

@JulianKast JulianKast changed the base branch from release/5.1.1_RC to 5.1.1 April 30, 2021 13:44
@RHenigan RHenigan merged commit a4d9b2b into 5.1.1 Apr 30, 2021
@RHenigan RHenigan deleted the ReadMeFix branch April 30, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update ReadMe for hotfix

3 participants