Skip to content

Conversation

@RHenigan
Copy link
Contributor

Fixes #1667

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android, Java SE, and Java EE

Unit Tests

N/a

Core Tests

Follow steps outlined in issue using java test suite

Core version / branch / commit hash / module tested against: 7.1
HMI name / version / branch / commit hash / module tested against: sdl_hmi 5.5.1

Summary

When the MaximumRpcPayloadSize is greater than the max queue size the queue capacity was being set to a decimal or 0 value. Adding a math.max to make sure it is always atleast 1.

CLA

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #1680 (e8d34ae) into develop (a0f080a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1680   +/-   ##
==========================================
  Coverage      53.94%   53.95%           
  Complexity      5307     5307           
==========================================
  Files            555      555           
  Lines          24562    24562           
  Branches        3101     3101           
==========================================
+ Hits           13251    13252    +1     
  Misses         10160    10160           
+ Partials        1151     1150    -1     
Impacted Files Coverage Δ Complexity Δ
...om/smartdevicelink/streaming/StreamPacketizer.java 56.89% <100.00%> (ø) 12.00 <0.00> (ø)
...tdevicelink/streaming/video/RTPH264Packetizer.java 71.00% <100.00%> (ø) 28.00 <0.00> (ø)
...rtdevicelink/streaming/video/SdlRemoteDisplay.java 51.21% <0.00%> (+1.21%) 5.00% <0.00%> (ø%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants