-
Notifications
You must be signed in to change notification settings - Fork 131
Fix Choice Cells and Menu Cells do not take which properties are available into account for uniqueness #1684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1684 +/- ##
=============================================
+ Coverage 54.22% 54.35% +0.13%
- Complexity 5351 5392 +41
=============================================
Files 555 555
Lines 24622 24702 +80
Branches 3122 3144 +22
=============================================
+ Hits 13351 13427 +76
+ Misses 10111 10108 -3
- Partials 1160 1167 +7
|
…ot support fields
… duplicate menu cells if some property of the cell is different but that property isn't actually displayed on the head unit.
bilal-alsharifi
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1682
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Unit Tests
Unit test were added in
MenuManagerTestsandChoiceSetManagerTestsCore Tests
Core version / branch / commit hash / module tested against: v7.1.1, Sync 3.0
HMI name / version / branch / commit hash / module tested against: generic_HMI v0.10.0 (current version), sdl_hmi v5.4.0 (one version back so that secondary / tertiary text isn't supported in menus), Sync 3.0
Summary
This PR updates the screen manager (menu manager and choice manager) to check the uniqueness of cells based on available screen properties on RPC v7.1+.
Changelog
Bug Fixes
CLA