Skip to content

Conversation

@bilal-alsharifi
Copy link
Contributor

@bilal-alsharifi bilal-alsharifi commented May 25, 2021

Fixes #1690

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android

Unit Tests

Added unit tests to test the workaround logic

Core Tests

On Sync 3.0:

  1. Connect a media app, it will start on the media template
  2. Change the layout to something else, like textAndGraphic
  3. Change the layout back to MEDIA
  4. Try to show another image and confirm it appears

Core version / branch / commit hash / module tested against: 7.1.1
HMI name / version / branch / commit hash / module tested against: Generic HMI 0.10.0

Summary

This PR updates the LifecycleManager to replace the incorrect capabilities that are included in the SetDisplayLayoutResponse for MEDIA apps with the ones from RegisterAppInterfaceResponse as a workaround to fix a bug in SYNC3.

Changelog

Bug Fixes

Workaround for a Ford Sync 3 bug where doing SetDisplayLayout to the MEDIA template would result in incorrect display capabilities being returned that claim the primaryGraphic is not supported.

CLA

@bilal-alsharifi bilal-alsharifi changed the title [WIP] Update SCM to workaround Sync 3 bug with media capabilities [WIP] Update LCM to workaround Sync 3 bug with media capabilities May 25, 2021
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #1694 (877639e) into develop (ad5fc1e) will increase coverage by 0.12%.
The diff coverage is 33.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1694      +/-   ##
=============================================
+ Coverage      54.15%   54.27%   +0.12%     
- Complexity      5336     5350      +14     
=============================================
  Files            555      555              
  Lines          24582    24640      +58     
  Branches        3108     3128      +20     
=============================================
+ Hits           13313    13374      +61     
+ Misses         10109    10108       -1     
+ Partials        1160     1158       -2     
Impacted Files Coverage Δ
...elink/managers/lifecycle/BaseLifecycleManager.java 14.19% <33.33%> (+0.35%) ⬆️
...ink/managers/screen/BaseTextAndGraphicManager.java 63.75% <0.00%> (-0.42%) ⬇️
...rtdevicelink/streaming/video/SdlRemoteDisplay.java 51.21% <0.00%> (+1.21%) ⬆️
...nk/managers/audio/AudioDecoderCompatOperation.java 79.54% <0.00%> (+4.54%) ⬆️
.../managers/screen/menu/BaseVoiceCommandManager.java 79.28% <0.00%> (+13.32%) ⬆️
...tdevicelink/managers/screen/menu/VoiceCommand.java 86.95% <0.00%> (+26.08%) ⬆️

@bilal-alsharifi bilal-alsharifi changed the title [WIP] Update LCM to workaround Sync 3 bug with media capabilities Update LCM to workaround Sync 3 bug with media capabilities May 25, 2021
@JulianKast JulianKast merged commit 0c3b2af into develop May 25, 2021
@JulianKast JulianKast deleted the feature/issue_1690 branch May 25, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants