Add onClose callbacks after LCM clean() calls #1698
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1697
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Core Tests
Tests performed:
SystemInfocheck failUnregisterAppInterfaceand receiving a responseOnAppInterfaceUnregisterednotification. (Triggered via SDL_HMI ignition cycle)Test code can be used to trigger an
OnAppInterfaceUnregisteredfrom the library. In theBaseLifecycleManagerwhere RPCs are received, after the RAI processes the following code can be added to trigger a sending of the notification.Summary
There exists a timing issue where the LCM can call for the lower layers to shutdown which will cause a flag to be set in the TransportManager that prevents the
onTransportDisconnectedcallback from being triggered. Because of this, no layers above theTransportManagerare notified. Simply adding theonClosecall in the LCM after the calls toclean()the LCM will trigger the necessary callbacks.Changelog
Bug Fixes
CLA