Fix MenuManager sending secondary image with menuCells when menuCommandSecondaryImage is not supported #1708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1688
This PR is [ready] for review.
Risk
This PR makes [minor] API changes.
Testing Plan
Core Tests
Remove ImageFilds
menuCommandSecondaryImageandmenuSubMenuSecondaryImagefrom generic HMI as a supported field. To do this you need to remove all instances of them insrc/js/controllers/DisplayCapabilities.jsand rebuild the hmiTest 1:
Step 1. With ImageField "menuCommandSecondaryImage" removed as a supported field from generic_hmi, Upload a menu with a normal cell that uses the same image for primary and secondary.
Verify: Only primary image is uploaded on menuCell.
Test 2:
With ImageField "menuSubMenuSecondaryImage" removed as a supported field from generic_hmi, Upload a menu with a menu cell that has subCells that uses the same image for primary and secondary.
Verify: Only primary image is uploaded on menuCell.
Core version / branch / commit hash / module tested against: Core 7.1
HMI name / version / branch / commit hash / module tested against: generic_hmi 0.10.0
Summary
Fix MenuManager sending a secondary image with menuCells when menuCommandSecondaryImage is not supported by HMI if file had previously uploaded
Changelog
Bug Fixes
CLA