Refactor ChoiceSetManager to Fix several bugs#1722
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1722 +/- ##
=============================================
- Coverage 54.13% 53.99% -0.15%
- Complexity 5429 5430 +1
=============================================
Files 555 554 -1
Lines 25082 25214 +132
Branches 3232 3278 +46
=============================================
+ Hits 13579 13614 +35
- Misses 10313 10381 +68
- Partials 1190 1219 +29
|
added 9 commits
July 26, 2021 09:53
JulianKast
requested changes
Aug 5, 2021
Contributor
JulianKast
left a comment
There was a problem hiding this comment.
@RHenigan after my first review, I noticed a few small things.
added 2 commits
August 9, 2021 09:40
JulianKast
requested changes
Aug 12, 2021
JulianKast
requested changes
Aug 18, 2021
added 14 commits
August 26, 2021 15:41
JulianKast
requested changes
Sep 13, 2021
JulianKast
requested changes
Sep 16, 2021
JulianKast
requested changes
Sep 16, 2021
…et/PreloadPresentChoicesOperation.java Co-authored-by: Julian Kast <Julian.kast@livio.io>
…et/PreloadPresentChoicesOperation.java Co-authored-by: Julian Kast <Julian.kast@livio.io>
Co-authored-by: Julian Kast <Julian.kast@livio.io>
…dl_java_suite into bugfix/issue_1717_1718
JulianKast
approved these changes
Sep 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1717, #1718
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
Updated unit test for new operation
Core Tests
Tested send in a presentation, then sending another presentation when the first has a button pressed
Smoke Tests for choiceset manager
Core version / branch / commit hash / module tested against: Manticore (SDL v7.1.1)
HMI name / version / branch / commit hash / module tested against: (Generic HMI v0.10.0)
Summary
CLA