Skip to content

Conversation

@bilal-alsharifi
Copy link
Contributor

Fixes #1760

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android

Summary

This PR adds a warning message for when the developer tries to send a MenuCell with SubCells and voice commands, because the AddSubMenu RPC does not support voice commands

CLA

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #1761 (e82a220) into release/5.3.0_RC (13a7d2f) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##             release/5.3.0_RC    #1761      +/-   ##
======================================================
- Coverage               54.39%   54.33%   -0.07%     
- Complexity               5501     5507       +6     
======================================================
  Files                     562      562              
  Lines                   25463    25518      +55     
  Branches                 3316     3326      +10     
======================================================
+ Hits                    13851    13864      +13     
- Misses                  10356    10393      +37     
- Partials                 1256     1261       +5     
Impacted Files Coverage Δ
...ink/managers/screen/menu/MenuReplaceUtilities.java 67.47% <0.00%> (-0.67%) ⬇️
...rtdevicelink/streaming/video/SdlRemoteDisplay.java 50.00% <0.00%> (-1.22%) ⬇️
...com/smartdevicelink/util/MediaStreamingStatus.java 63.80% <0.00%> (-0.96%) ⬇️
...ink/managers/screen/BaseTextAndGraphicManager.java 64.16% <0.00%> (-0.42%) ⬇️
...va/com/smartdevicelink/session/BaseSdlSession.java 20.17% <0.00%> (+1.31%) ⬆️
...agers/screen/menu/VoiceCommandUpdateOperation.java 78.74% <0.00%> (+2.36%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants