Skip to content

Conversation

@joeygrover
Copy link
Member

Changelog

Remove unnecessary SdlException throw in SdlManager

CLA

@codecov-io
Copy link

codecov-io commented Oct 23, 2018

Codecov Report

Merging #911 into hotfix/4.7.1 will decrease coverage by 2.52%.
The diff coverage is 43.75%.

Impacted file tree graph

@@                Coverage Diff                @@
##             hotfix/4.7.1    #911      +/-   ##
=================================================
- Coverage           42.62%   40.1%   -2.53%     
- Complexity           3734    3739       +5     
=================================================
  Files                 434     434              
  Lines               23048   24633    +1585     
  Branches             2690    3077     +387     
=================================================
+ Hits                 9825    9879      +54     
- Misses              12577   14100    +1523     
- Partials              646     654       +8
Impacted Files Coverage Δ Complexity Δ
.../java/com/smartdevicelink/managers/SdlManager.java 44.23% <43.75%> (-0.92%) 50 <0> (ø)
...n/java/com/smartdevicelink/proxy/SdlProxyBase.java 5.48% <0%> (-1.08%) 20% <0%> (+5%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5deb3a3...8e4d447. Read the comment docs.

@joeygrover joeygrover merged commit 93981e8 into hotfix/4.7.1 Oct 24, 2018
@joeygrover joeygrover deleted the hotfix/remove_sdlexception_throw branch October 24, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants