WebSocket Server Support for Multiple Client Connections#102
Merged
nickschwab merged 3 commits intodevelopfrom Jan 17, 2020
Merged
WebSocket Server Support for Multiple Client Connections#102nickschwab merged 3 commits intodevelopfrom
nickschwab merged 3 commits intodevelopfrom
Conversation
…ion to the server + updated Node.js example project to utilize modified transport
russjohnson09
suggested changes
Jan 9, 2020
Contributor
russjohnson09
left a comment
russjohnson09
left a comment
There was a problem hiding this comment.
The changes looked good to me. I've tested this using multiple connections and haven't seen any issues. I think the ping interval needs to be cleared once the client connection is terminated.
russjohnson09
approved these changes
Jan 9, 2020
crokita
approved these changes
Jan 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Run the Node.js example app and connect 2 or more Core clients to it simultaneously.
Summary
Changed the WebSocketServer transport to act in scope of a single client connected to the server to allow for multiple, isolated client connections. This change is heavily based off of the Java Suite's implementation and intended use of the WebSocketServer transport.
A working example of this can be found in the Node.js example project.
CLA