Hotfix/missing permissions #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update function_group_info.is_proprietary_group property to true for the functional groups: "PropriataryData-1", "PropriataryData-2" and "PropriataryData-3.
Update function_group_info.is_proprietary_group property to true for the functional groups: "PropriataryData-1", "PropriataryData-2" and "PropriataryData-3.
crokita
commented
Jun 8, 2022
Contributor
Author
crokita
left a comment
crokita
left a comment
There was a problem hiding this comment.
See feedback @RaedAlmomani
Co-authored-by: Chris <chris@livio.io>
Co-authored-by: Chris <chris@livio.io>
renonick87
approved these changes
Jun 15, 2022
Contributor
Author
|
Unit tests failed due to the new changes. Determined that the tests for the applications/groups route weren't testing the route properly. There's now one GET and one PUT to test updating proprietary functional group assignment to apps. Needs a re-review. |
renonick87
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #297
This PR is ready for review.
Risk
This PR is a hotfix. Minor package changes have been made to resolve some vulnerabilities.
Summary
Adds the OnTBTClientState RPC in the most recent changes for the Navigation-1 functional group in staging and production. Marks the PropriataryData-1, PropriataryData-2, PropriataryData-3 functional groups as proprietary such that they can be explicitly assigned to incoming app reviews at the policy server user's discretion.