Skip to content

Pre-commit hook comment in drop-noop-approve-step.sh is misleading — hooks don't transfer on clone #36

Description

@smartwatermelon

Non-Blocking Review Concern: Pre-commit hook comment in drop-noop-approve-step.sh is misleading — hooks don't transfer on clone

Source: pre-push whole-codebase review
Location: scripts/drop-noop-approve-step.sh:149
Date: 2026-08-03

What was flagged

Lines 149–152 comment that a "commit failure here may be a pre-commit hook rejecting the change." Git hooks are not cloned with repositories — the local hooks at ~/.config/git/hooks/ or .git/hooks/ of each target repo are not present in a fresh git clone. The commit at line 153 will run without any hook enforcement regardless of what's installed in those repos locally. The comment should either be removed or corrected to note that the hooks will not run in freshly-cloned scratch directories. As written, this comment could mislead a future operator into believing hook-enforced review is happening when it isn't.

Context

This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.


Created by lib-review-issues.sh

Metadata

Metadata

Assignees

No one assigned

    Labels

    tech-debtTechnical debt to address

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions