Non-Blocking Review Concern: "Minimize PASS review comment" escape hatch regex doesn't match SHA-scoped skip markers
Source: pre-push whole-codebase review
Location: .github/workflows/claude-blocking-review.yml:666
Date: 2026-08-07
What was flagged
The regex \[skip-claude-review(\]|:) matches [skip-claude-review] and [skip-claude-review: reason] but NOT the new SHA-scoped form [skip-claude-review sha=abc1234: reason] (the character after skip-claude-review is a space, not ] or :). In the current execution flow this is harmless: when a SHA-scoped skip fires in "Check review verdict," no Claude review runs and no PASS comment is ever posted, so the minimize step bails at "No verdict file — nothing to minimize." However, the regex is now inconsistent with the documented escape hatch syntax, which will confuse future maintainers and could become a real bug if the step ordering or skip logic changes. Consider updating the pattern to \[skip-claude-review[ \]:] or \[skip-claude-review(\]| sha=|:) to cover all documented forms.
Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh
Non-Blocking Review Concern: "Minimize PASS review comment" escape hatch regex doesn't match SHA-scoped skip markers
Source: pre-push whole-codebase review
Location:
.github/workflows/claude-blocking-review.yml:666Date: 2026-08-07
What was flagged
The regex
\[skip-claude-review(\]|:)matches[skip-claude-review]and[skip-claude-review: reason]but NOT the new SHA-scoped form[skip-claude-review sha=abc1234: reason](the character afterskip-claude-reviewis a space, not]or:). In the current execution flow this is harmless: when a SHA-scoped skip fires in "Check review verdict," no Claude review runs and no PASS comment is ever posted, so the minimize step bails at "No verdict file — nothing to minimize." However, the regex is now inconsistent with the documented escape hatch syntax, which will confuse future maintainers and could become a real bug if the step ordering or skip logic changes. Consider updating the pattern to\[skip-claude-review[ \]:]or\[skip-claude-review(\]| sha=|:)to cover all documented forms.Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh