Non-Blocking Review Concern: "Minimize PASS review comment" silently ignores too-short sha= values without warning
Source: pre-push whole-codebase review
Location: .github/workflows/claude-blocking-review.yml:678
Date: 2026-08-07
What was flagged
When the SHA-scoped marker has a sha= value shorter than 7 characters, the "Check review verdict" step emits a ::warning:: explaining the rejection and proceeds with review. The "Minimize PASS review comment" step has no equivalent branch — it silently falls through to the minimize logic without any log message. This is a behavioral asymmetry: an operator who added an invalid sha=a marker and saw the warning in the verdict step might expect the same warning in the minimize step's logs when debugging unexpected behavior. Not a correctness bug since the minimize step is non-fatal, but it makes the two implementations harder to reason about together.
Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh
Non-Blocking Review Concern: "Minimize PASS review comment" silently ignores too-short
sha=values without warningSource: pre-push whole-codebase review
Location:
.github/workflows/claude-blocking-review.yml:678Date: 2026-08-07
What was flagged
When the SHA-scoped marker has a
sha=value shorter than 7 characters, the "Check review verdict" step emits a::warning::explaining the rejection and proceeds with review. The "Minimize PASS review comment" step has no equivalent branch — it silently falls through to the minimize logic without any log message. This is a behavioral asymmetry: an operator who added an invalidsha=amarker and saw the warning in the verdict step might expect the same warning in the minimize step's logs when debugging unexpected behavior. Not a correctness bug since the minimize step is non-fatal, but it makes the two implementations harder to reason about together.Context
This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.
Created by lib-review-issues.sh