Skip to content

"Minimize PASS review comment" silently ignores too-short sha= values without warning #92

Description

@twistedmelonman

Non-Blocking Review Concern: "Minimize PASS review comment" silently ignores too-short sha= values without warning

Source: pre-push whole-codebase review
Location: .github/workflows/claude-blocking-review.yml:678
Date: 2026-08-07

What was flagged

When the SHA-scoped marker has a sha= value shorter than 7 characters, the "Check review verdict" step emits a ::warning:: explaining the rejection and proceeds with review. The "Minimize PASS review comment" step has no equivalent branch — it silently falls through to the minimize logic without any log message. This is a behavioral asymmetry: an operator who added an invalid sha=a marker and saw the warning in the verdict step might expect the same warning in the minimize step's logs when debugging unexpected behavior. Not a correctness bug since the minimize step is non-fatal, but it makes the two implementations harder to reason about together.

Context

This issue was automatically created from a non-blocking concern identified
during pre-push whole-codebase review. It was flagged for tracking.


Created by lib-review-issues.sh

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    tech-debtTechnical debt to address

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions