Skip to content

Continue work on the Stacktrace View. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jul 27, 2014
Merged

Continue work on the Stacktrace View. #2

merged 22 commits into from
Jul 27, 2014

Conversation

@smashwilson
Copy link
Owner

@smashwilson smashwilson commented Jul 26, 2014

It should show you data and context for each frame within the trace, and should:

  • Show a few lines of context around each stack frame's line.
  • Jump to any given frame's location in source.
  • Collapse each frame.
  • Make the current trace the "active" one (done automatically during 1) or "deactivate" it.

smashwilson added 22 commits July 26, 2014 17:00
@smashwilson
Stacktrace.parse() returns multiple results now.
a4f22c3
@smashwilson
Spec for rendering the error message.
45b8506
@smashwilson
Rendering a subview for each Frame.
e250a0b
@smashwilson
Specs for FrameView.
3e1c1f7
@smashwilson
Stub out controls for activation and deactivation.
2387c86
@smashwilson
Toggle each FrameView.
f62810c
@smashwilson
Oops, broke that test when I renamed path.
2958639
@smashwilson
Test case for fetching line context.
8aadb50
@smashwilson
Use line-chomper to read files by lines.
d6d4041
@smashwilson
Implement Frame.getContext().
701598c
@smashwilson
Use my line-chomper fork.
b306d95 
So I can disable the automatic `.trim()`.
@smashwilson
Use a mini-EditorView to show code snippets.
840d863
@smashwilson
Hey look an off-by-one error
70d5e3b
@smashwilson
Navigate to a specific Frame.
3bf2b3c
@smashwilson
Navigate on a click anywhere in the frame.
267140a 
I'm not so sure about this one.
@smashwilson
Mark the currently "active" Stacktrace.
c7f9779
@smashwilson
Wire up the activate and deactivate events.
6f338d5
@smashwilson
Depend on Emissary for event stuff.
b7de299
@smashwilson
Emit events when the active Stacktrace is changed.
28b8eae
@smashwilson
Toggle the StacktraceView class on activation.
1850e30
@smashwilson
Activate the Stacktrace on navigation.
1190bce
@smashwilson
Unsubscribe on view close.
12db069
smashwilson added a commit that referenced this pull request Jul 27, 2014
@smashwilson
Merge pull request #2 from smashwilson/trace-view
c849b82 
Continue work on the Stacktrace View.
@smashwilson smashwilson merged commit c849b82 into master Jul 27, 2014
@smashwilson smashwilson deleted the trace-view branch July 27, 2014 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smashwilson