pmd fix insufficient data after filter#222
Merged
andrewdavidsmith merged 3 commits intomasterfrom Jun 4, 2024
Merged
Conversation
Collaborator
andrewdavidsmith
commented
Jun 4, 2024
- src/common/TwoStatHMM_PMD.cpp: Formatting code
- src/analysis/pmd.cpp: adding an additional check for sufficient data after filtering bins based on deserts
- src/analysis/pmd.cpp: changing the min required bins for inference to be 100. It's not clear if this is important because the bins after filtering will be sufficient if the data is good, and if this is a problem, the number of bins will be extremely small
…after filtering bins based on deserts
… be 100. It's not clear if this is important because the bins after filtering will be sufficient if the data is good, and if this is a problem, the number of bins will be extremely small
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.