fix: when passing in arguments, compare by lowercase #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kneekey23
reviewed
Aug 6, 2021
| // when you instantiate that struct you have to call params in order with their param names. if you don't it won't compile | ||
| // so we sort here before we write any of the members with their values | ||
| val sortedMembers = node.members.toSortedMap(compareBy<StringNode> { it.value }) | ||
| val sortedMembers = node.members.toSortedMap(compareBy<StringNode> { it.value.lowercase() }) |
Contributor
There was a problem hiding this comment.
how did this ever work anywhere else? lol
Contributor
Author
There was a problem hiding this comment.
members were always lower cased somehow?
kneekey23
approved these changes
Aug 6, 2021
Contributor
kneekey23
left a comment
kneekey23
left a comment
There was a problem hiding this comment.
seems liek ci passes so I trust it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corresponding:
awslabs/aws-sdk-swift#304
this allows restxml-namespace protocol codegen tests to compile properly.. hopefully it doesn't break anything else.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.