Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ class ShapeValueGenerator(
// this is important because when a struct is generated in swift it is generated with its members sorted by name.
// when you instantiate that struct you have to call params in order with their param names. if you don't it won't compile
// so we sort here before we write any of the members with their values
val sortedMembers = node.members.toSortedMap(compareBy<StringNode> { it.value })
val sortedMembers = node.members.toSortedMap(compareBy<StringNode> { it.value.lowercase() })
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did this ever work anywhere else? lol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

members were always lower cased somehow?

sortedMembers.forEach { (keyNode, valueNode) ->
val memberShape: Shape
when (currShape) {
Expand Down