test: new ruby 3.5 #146
test: new ruby 3.5 #146
Conversation
|
Warning Rate limit exceeded@pftg has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 48 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughUpdated CI matrix: removed Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant GH as GitHub Actions
participant M as Matrix Expander
participant J_preview_rails81 as Job: 3.5.0-preview1 + rails81_gems
participant J_preview_edge as Job: 3.5.0-preview1 + edge_gems
participant J_jruby_head as Job: jruby-head + rails80_gems
participant T as Test Runner
Dev->>GH: Push / PR triggers workflow
GH->>M: Read .github/workflows/test.yml
Note over M: Matrix now includes preview and jruby-head entries\nand excludes jruby-9.4+rails81 (non-experimental)
M-->>GH: Expanded matrix
GH->>J_preview_rails81: Start job (preview + rails81_gems)
GH->>J_preview_edge: Start job (preview + edge_gems)
GH->>J_jruby_head: Start job (jruby-head + rails80_gems)
J_preview_rails81->>T: Install deps & run tests
J_preview_edge->>T: Install deps & run tests
J_jruby_head->>T: Install deps & run tests
T-->>GH: Report job results
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/test.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Functional Test
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/test.yml (1)
9-9: GitHub Actions key should betypes, nottypeUsing
typeis ignored;review_requestedevents won’t trigger as intended.- pull_request: - type: [ opened, synchronize, reopened, review_requested ] + pull_request: + types: [ opened, synchronize, reopened, review_requested ]
🧹 Nitpick comments (2)
lib/capybara/screenshot/diff/area_calculator.rb (2)
51-51: Rename tap block param to plural for clarityThe block receives an Array of regions; plural reads better and avoids confusion with Region.
- .tap { |region| region.compact! } + .tap { |regions| regions.compact! }
22-23: Fix typo in comment“to eb relative” → “to be relative”.
- # and if there is crop then makes absolute coordinates to eb relative to crop top left corner + # and if there is crop then makes absolute coordinates to be relative to crop top-left corner
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/test.yml(2 hunks)lib/capybara/screenshot/diff/area_calculator.rb(1 hunks)lib/capybara_screenshot_diff/screenshot_assertion.rb(1 hunks)
🔇 Additional comments (3)
lib/capybara_screenshot_diff/screenshot_assertion.rb (1)
21-23: LGTM: clearer tap block paramRenaming
ittoassertionimproves readability; no functional change..github/workflows/test.yml (2)
101-101: Add rails81_gems.rb to matrix — looks goodKeeps coverage current with Rails 8.1.
112-114: Exclude jruby-9.4 + rails81 — good guardrailJRuby 9.4 targets Ruby 3.1; Rails 8.x needs ≥3.2.
There was a problem hiding this comment.
Pull Request Overview
Updates the CI matrix to add experimental support for Ruby 3.5.0-preview1, adds Rails 8.1 support, and removes Rails 7.0 from the test matrix.
- Added Ruby 3.5.0-preview1 experimental testing for Rails 8.1 and edge versions
- Added Rails 8.1.0.beta1 support via new gemfile
- Removed Rails 7.0 from CI matrix and excluded JRuby from Rails 8.1 testing
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/test.yml | Updates CI matrix to add Ruby 3.5 experimental runs, Rails 8.1, and removes Rails 7.0 |
| gemfiles/rails81_gems.rb | Adds new Rails 8.1.0.beta1 dependency configuration |
| lib/capybara_screenshot_diff/screenshot_assertion.rb | Renames variable from 'it' to 'assertion' for clarity |
| lib/capybara/screenshot/diff/area_calculator.rb | Renames variable from 'it' to 'region' for clarity |
| test/support/test_helpers.rb | Adds whitespace line for formatting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Summary by CodeRabbit