Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,10 @@ jobs:
matrix:
ruby-version: [ 3.4, 3.3, 3.2, jruby-9.4, jruby-10.0 ]
gemfile:
- rails70_gems.rb
- rails71_gems.rb
- rails72_gems.rb
- rails80_gems.rb
- rails81_gems.rb
experimental: [ false ]
exclude:
# We already tested last version
Expand All @@ -109,7 +109,16 @@ jobs:
- ruby-version: jruby-9.4
gemfile: rails80_gems.rb
experimental: false
- ruby-version: jruby-9.4
gemfile: rails81_gems.rb
experimental: false
include:
- ruby-version: 3.5.0-preview1
gemfile: rails81_gems.rb
experimental: true
- ruby-version: 3.5.0-preview1
gemfile: edge_gems.rb
experimental: true
- ruby-version: 3.4
gemfile: edge_gems.rb
experimental: true
Expand Down
7 changes: 7 additions & 0 deletions gemfiles/rails81_gems.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# frozen_string_literal: true

gems = "#{File.dirname __dir__}/gems.rb"
eval File.read(gems), binding, gems

gem "activesupport", "~> 8.1.0.beta1"
gem "actionpack", "~> 8.1.0.beta1"
2 changes: 1 addition & 1 deletion lib/capybara/screenshot/diff/area_calculator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def calculate_skip_area
def build_regions_for(coordinates)
coordinates
.map { |entry| Region.from_edge_coordinates(*entry) }
.tap { |it| it.compact! }
.tap { |region| region.compact! }
end
end
end
Expand Down
6 changes: 3 additions & 3 deletions lib/capybara_screenshot_diff/screenshot_assertion.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ def self.from(screenshot_job)
return screenshot_job if screenshot_job.is_a?(ScreenshotAssertion)

caller, name, compare = screenshot_job
ScreenshotAssertion.new(name).tap do |it|
it.caller = caller
it.compare = compare
ScreenshotAssertion.new(name).tap do |assertion|
assertion.caller = caller
assertion.compare = compare
end
end

Expand Down
1 change: 1 addition & 0 deletions test/support/test_helpers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

module TestHelpers
include Capybara::Screenshot::Diff::TestDoubles

# Common assertions for image comparison tests
module Assertions
# Asserts that a dimension check was called a specific number of times
Expand Down
Loading