This repository was archived by the owner on Sep 19, 2024. It is now read-only.
Merged
Conversation
jgoux
approved these changes
Mar 23, 2023
Contributor
|
Good catch, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TIL that
GITHUB_SHAis a ghost commit with the same content but with a different sha when it is triggered from a PR workflow 🙈https://github.com/orgs/community/discussions/26325
So because the workflow is triggered from a Pull request we pull the commit with the wrong sha and add the status to the wrong commit after the Vercel build is done.
That's why the status check never gets updated from
Canceled by Ignored Build Step.Fix here is not to rely on
GITHUB_SHAbut instead get it directly from the context if available.Related discussion: vercel/vercel#8328 (reply in thread)