Skip to content

feat(controller): add tweak preview session (#658)#659

Merged
plastikfan merged 1 commit into
mainfrom
feat/tweak-preview-session-and-view-isolation-audit
Jul 4, 2026
Merged

feat(controller): add tweak preview session (#658)#659
plastikfan merged 1 commit into
mainfrom
feat/tweak-preview-session-and-view-isolation-audit

Conversation

@plastikfan

@plastikfan plastikfan commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Added support for disposable preview sessions that can be marked complete and report basic completion status.
    • Added a new theme update message to carry theme changes through the app.
  • Tests

    • Added coverage for preview session behavior, including completion tracking and default timing values.

@plastikfan plastikfan self-assigned this Jul 4, 2026
@plastikfan plastikfan added the feature New feature or request label Jul 4, 2026
@plastikfan
plastikfan merged commit 2e1182b into main Jul 4, 2026
4 of 5 checks passed
@plastikfan
plastikfan deleted the feat/tweak-preview-session-and-view-isolation-audit branch July 4, 2026 14:19
@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ce7db6cd-6610-4d67-8bc5-c76d6a63a56f

📥 Commits

Reviewing files that changed from the base of the PR and between 1a36879 and dd97c76.

📒 Files selected for processing (3)
  • src/app/controller/preview-session.go
  • src/app/controller/preview-session_test.go
  • src/prism/contract/messages.go

📝 Walkthrough

Walkthrough

Adds a PreviewSession type in the controller package implementing core.Session, with atomic completion tracking and stubbed timing methods, plus a Ginkgo/Gomega test suite. Also adds a new ThemeUpdateMsg struct to the prism contract package.

Changes

Preview Session Implementation

Layer / File(s) Summary
PreviewSession core type
src/app/controller/preview-session.go
Adds PreviewSession with atomic completion flag, NewPreviewSession constructor, IsComplete/MarkComplete methods, stubbed StartedAt/Elapsed, and a compile-time core.Session interface check.
PreviewSession tests
src/app/controller/preview-session_test.go
Adds Ginkgo/Gomega tests verifying initial state, idempotent MarkComplete, zero-value timing methods, and interface satisfaction of core.Session.

Theme Update Message

Layer / File(s) Summary
ThemeUpdateMsg struct
src/prism/contract/messages.go
Adds new exported ThemeUpdateMsg struct carrying a Theme field.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Estimated code review effort: 1 (Trivial) | ~5 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/tweak-preview-session-and-view-isolation-audit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@plastikfan plastikfan linked an issue Jul 4, 2026 that may be closed by this pull request
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tweak preview session and view isolation audit

1 participant