Skip to content

Comments

fix: warning: disallowed conversion from string literal to 'char*'#106

Merged
sergio-nsk merged 1 commit intomasterfrom
sergio-nsk-patch-1
Jul 3, 2025
Merged

fix: warning: disallowed conversion from string literal to 'char*'#106
sergio-nsk merged 1 commit intomasterfrom
sergio-nsk-patch-1

Conversation

@sergio-nsk
Copy link
Collaborator

No description provided.

@sergio-nsk sergio-nsk requested a review from nmoinvaz July 2, 2025 06:25
@sergio-nsk sergio-nsk added the warnings fix Fixes to compiler warnings label Jul 2, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.53%. Comparing base (4e7cd4f) to head (d048127).

Files with missing lines Patch % Lines
execute_jscore.c 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   62.84%   62.53%   -0.31%     
==========================================
  Files          32       32              
  Lines        2597     2597              
  Branches      521      521              
==========================================
- Hits         1632     1624       -8     
- Misses        612      621       +9     
+ Partials      353      352       -1     
Flag Coverage Δ
macos 59.02% <0.00%> (-0.33%) ⬇️
macos_duktape 64.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nmoinvaz
Copy link
Collaborator

nmoinvaz commented Jul 2, 2025

Looks like linting is failing

@sergio-nsk sergio-nsk force-pushed the sergio-nsk-patch-1 branch from f51684e to d048127 Compare July 3, 2025 00:22
@sergio-nsk sergio-nsk merged commit ca1daf8 into master Jul 3, 2025
29 of 30 checks passed
@sergio-nsk sergio-nsk deleted the sergio-nsk-patch-1 branch July 3, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

warnings fix Fixes to compiler warnings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants