Skip to content

Revert "Merge pull request #1601 from snyk/feat/iac-experimental-local-exec" - #1615

Merged
JackuB merged 2 commits into
masterfrom
revert/fix-git-less-install
Feb 4, 2021
Merged

Revert "Merge pull request #1601 from snyk/feat/iac-experimental-local-exec"#1615
JackuB merged 2 commits into
masterfrom
revert/fix-git-less-install

Conversation

@JackuB

@JackuB JackuB commented Feb 4, 2021

Copy link
Copy Markdown
Contributor

Fixes #1614
Fixes #1613

The git url in the package.json dependency is causing issues installing

@JackuB
JackuB requested a review from a team as a code owner February 4, 2021 16:08
@JackuB
JackuB requested a review from a team February 4, 2021 16:08
@JackuB
JackuB requested a review from a team as a code owner February 4, 2021 16:08
@JackuB
JackuB force-pushed the revert/fix-git-less-install branch from d1e97dd to 76ceaa0 Compare February 4, 2021 16:09
@github-actions

github-actions Bot commented Feb 4, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor
Warnings
⚠️ You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against 79a326b

JackuB added 2 commits February 4, 2021 17:16
@JackuB
fix: remove dependency that was using git URL and failing installs
3df91ac 
This reverts commit 40e7136, reversing
changes made to 7775c04.

git url is causing issues installing the CLI in envs without global git command
@JackuB
chore: remove prerelease flag for Lerna
79a326b
@JackuB
JackuB force-pushed the revert/fix-git-less-install branch from 5b367f7 to 79a326b Compare February 4, 2021 16:17
@github-actions

github-actions Bot commented Feb 4, 2021 •
edited by JackuB
Loading

Copy link
Copy Markdown
Contributor

Expected release notes (by @JackuB)

fixes:
remove dependency that was using git URL and failing installs (3df91ac)

others (will not be included in Semantic-Release notes):
remove prerelease flag for Lerna (79a326b)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@JackuB

JackuB commented Feb 4, 2021

Copy link
Copy Markdown
Contributor Author

Deprecated snyk@1.442.0 and snyk@1.441.0 package version on npm

@JackuB
JackuB merged commit 1606fbd into master Feb 4, 2021
@JackuB
JackuB deleted the revert/fix-git-less-install branch February 4, 2021 16:54
This was referenced May 21, 2021
Closed
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@rontalx rontalx rontalx approved these changes
@maxjeffos maxjeffos maxjeffos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🐛] Impossible to install npm snyk 1.441.0, if git command is not available [🐛] Impossible to install npm snyk 1.441.0 globally

3 participants

@JackuB @rontalx @maxjeffos