Skip to content

re-release iac experimental single k8s file - with NPM dependency - #1621

Merged
rontalx merged 1 commit into
masterfrom
feat/iac-experimental-local-exec
Feb 8, 2021
Merged

re-release iac experimental single k8s file - with NPM dependency#1621
rontalx merged 1 commit into
masterfrom
feat/iac-experimental-local-exec

Conversation

@rontalx

@rontalx rontalx commented Feb 8, 2021

Copy link
Copy Markdown
Contributor

This PR is an exact replica of this PR which was merged & reverted:
#1601
it was reverted due to an incident with the git url dependency (#incident-cli-git-url-dependency).
The only change is that now it uses a public npm version instead of the git one.

@rontalx
rontalx requested a review from a team as a code owner February 8, 2021 09:27
@rontalx
rontalx requested a review from a team February 8, 2021 09:27
@rontalx
rontalx requested a review from a team as a code owner February 8, 2021 09:27
@github-actions

github-actions Bot commented Feb 8, 2021

Copy link
Copy Markdown
Contributor

Expected release notes (by @rontalx)

features:
iac experimental single k8s file (f232cfb)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@rontalx rontalx changed the title feat: iac experimental single k8s file re-release iac experimental single k8s file - with NPM dependency Feb 8, 2021
@github-actions

github-actions Bot commented Feb 8, 2021

Copy link
Copy Markdown
Contributor
Warnings
⚠️

Looks like you added a new Tap test. Consider making it a Jest test instead. See files like test/*.spec.ts for examples. Files found:

  • test/smoke/.iac-data/data.json
  • test/smoke/.iac-data/policy.wasm
  • test/smoke/spec/iac/snyk_test_local_exec_spec.sh
Messages
📖 You are modifying something in test/smoke directory, yet you are not on the branch starting with smoke/. You can prefix your branch with smoke/ and Smoke tests will trigger for this PR.

Generated by 🚫 dangerJS against f232cfb

@aron aron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better!

@rontalx
rontalx merged commit 15f1728 into master Feb 8, 2021
@rontalx
rontalx deleted the feat/iac-experimental-local-exec branch February 8, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants