Fix/alert if path with filename - #232
Merged
Merged
Conversation
lili2311
reviewed
Oct 8, 2018
Contributor
There was a problem hiding this comment.
can we just disable this rule in the config please? It is too restrictive I think.
Kirill89
force-pushed
the
fix/alert-if-path-with-filename
branch
from
October 8, 2018 14:15
a029e7a to
b5217fd
Compare
lili2311
approved these changes
Oct 8, 2018
lili2311
reviewed
Oct 8, 2018
| function checkPaths(args) { | ||
| for (const path of args.options._) { | ||
| if (typeof path === 'string' && isPathToPackageFile(path)) { | ||
| throw new Error(`Path "${path}" contains package file name, ` + |
Contributor
There was a problem hiding this comment.
I am a little worried package is not clear enough, maybe we can do something like:
Not a recognised option did you mean --file=${path}
|
🎉 This PR is included in version 1.102.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 tasks
This was referenced Jul 31, 2020
This was referenced Nov 30, 2022
This was referenced Nov 30, 2022
This was referenced Dec 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Check if user specify package file name as part of path and throw error if so.
Where should the reviewer start?
src/cli/index.ts
How should this be manually tested?
snyk test rubygems/Gemfile.lockJira?
SC-6271