support tags/attributes in Docker projects & alias --project-tags to --tags - #2330
Merged
Conversation
jaysh
requested review from
a team,
admons,
cristian-pana,
dtrunley-snyk,
ekbsnyk,
muscar and
tonidevine1
October 29, 2021 15:12
Contributor
|
darscan
reviewed
Nov 2, 2021
ghost
reviewed
Nov 2, 2021
ivanstanev
reviewed
Nov 3, 2021
ghost
approved these changes
Nov 3, 2021
jaysh
force-pushed
the
feat/project-tags-attributes
branch
2 times, most recently
from
November 4, 2021 13:18
c52d225 to
1a7dbc8
Compare
jaysh
force-pushed
the
feat/project-tags-attributes
branch
from
November 5, 2021 17:52
1a7dbc8 to
e9e9b6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for
snyk container monitorto use--project-tags(and now--tags) as well as the project attributes (--project-lifecycle,--project-business-criticality,--project-environment).Where should the reviewer start?
How should this be manually tested?
Example command line:
Any background context you want to provide?
What are the relevant tickets?
Screenshots
Additional questions