Skip to content

support tags/attributes in Docker projects & alias --project-tags to --tags - #2330

Merged
jaysh merged 3 commits into
masterfrom
feat/project-tags-attributes
Nov 8, 2021
Merged

support tags/attributes in Docker projects & alias --project-tags to --tags#2330
jaysh merged 3 commits into
masterfrom
feat/project-tags-attributes

Conversation

@jaysh

@jaysh jaysh commented Oct 29, 2021

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR adds support for snyk container monitor to use --project-tags (and now --tags) as well as the project attributes (--project-lifecycle, --project-business-criticality, --project-environment).

Where should the reviewer start?

How should this be manually tested?

Example command line:

snyk container monitor alpine:3.14 --tags=container2=monitor5 --project-lifecycle=sandbox --project-environment=backend --project-business-criticality=critical

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@jaysh
jaysh requested review from a team as code owners October 29, 2021 15:12
@github-actions

github-actions Bot commented Oct 29, 2021

Copy link
Copy Markdown
Contributor
Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • src/cli/commands/monitor/index.ts
  • test/acceptance/cli-monitor/cli-monitor.acceptance.test.ts

Generated by 🚫 dangerJS against e9e9b6a

Comment thread src/lib/ecosystems/monitor.ts Outdated
Comment thread src/lib/ecosystems/types.ts
Comment thread src/lib/ecosystems/monitor.ts
@jaysh
jaysh force-pushed the feat/project-tags-attributes branch 2 times, most recently from c52d225 to 1a7dbc8 Compare November 4, 2021 13:18
@jaysh
jaysh force-pushed the feat/project-tags-attributes branch from 1a7dbc8 to e9e9b6a Compare November 5, 2021 17:52
@jaysh
jaysh merged commit 2f8b2e9 into master Nov 8, 2021
@jaysh
jaysh deleted the feat/project-tags-attributes branch November 8, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants