Skip to content

feat: '--gradle-sub-project' option to handle multip-project gradle - #234

Merged
michael-go merged 1 commit into
masterfrom
feat/gradle-sub-project-option
Oct 7, 2018
Merged

feat: '--gradle-sub-project' option to handle multip-project gradle#234
michael-go merged 1 commit into
masterfrom
feat/gradle-sub-project-option

Conversation

@michael-go

@michael-go michael-go commented Oct 7, 2018

Copy link
Copy Markdown
Contributor
  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

This bumps snyk-gradle-plugin to version 2.1.0 that supports the new flag: https://github.com/snyk/snyk-gradle-plugin/releases/tag/v2.1.0 (PR: snyk/snyk-gradle-plugin#18)

note this also appends the sub-project name to the root package name:

image

@michael-go michael-go self-assigned this Oct 7, 2018
@michael-go
michael-go force-pushed the feat/gradle-sub-project-option branch from 6fd5e5d to de73eb6 Compare October 7, 2018 10:10
Comment thread help/help.txt Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe without this part, as it is an implementation detail that belongs to the plugin? May change in the future or something?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... to target. -> ... to test.?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Gradle "multi project" configurations, test a specific sub-project.

?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, sounds better

note this also appends the sub-project name to the root package name
@michael-go
michael-go force-pushed the feat/gradle-sub-project-option branch from de73eb6 to e986f79 Compare October 7, 2018 10:17
@michael-go
michael-go merged commit 974949e into master Oct 7, 2018
@michael-go
michael-go deleted the feat/gradle-sub-project-option branch October 7, 2018 10:26
@snyksec

snyksec commented Oct 7, 2018

Copy link
Copy Markdown

🎉 This PR is included in version 1.101.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants