Skip to content

refactor: remove main cli export - #2367

Merged
1 commit merged into
masterfrom
refactor/remove-main-export
Nov 18, 2021
Merged

refactor: remove main cli export#2367
1 commit merged into
masterfrom
refactor/remove-main-export

Conversation

@ghost

@ghost ghost commented Nov 16, 2021

Copy link
Copy Markdown

We no longer export "main" in our package.json so we don't need this export.

We no longer export "main" in our package.json so we don't need this export.
@github-actions

Copy link
Copy Markdown
Contributor
Warnings
⚠️ You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?
Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against 14d9d82

@ghost
ghost marked this pull request as ready for review November 16, 2021 13:49
@ghost
ghost requested review from a team as code owners November 16, 2021 13:49
@ghost
ghost requested review from dekelund, ekbsnyk and tonidevine1 November 16, 2021 13:49

@maxjeffos maxjeffos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you don't really need this PR anymore since https://github.com/snyk/snyk/pull/2368/files includes this same change but approved it anyway so you can merge as you prefer.

@ghost

ghost commented Nov 16, 2021

Copy link
Copy Markdown
Author

@maxjeffos they are slightly different. #2368 still includes if (module.parent) { ... while the goal of this PR is to remove that.

@ghost
ghost merged commit d5a93da into master Nov 18, 2021
@ghost
ghost deleted the refactor/remove-main-export branch November 18, 2021 17:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant