chore: remove dud webpack loader exclude rule - #2370
Merged
1 commit merged intoNov 18, 2021
Merged
Conversation
When providing strings, Webpack matches absolute paths so the current rule excludes nothing. Fixing this by using a regex `/node_modules/` does not improve build performance at all since imports via node_modules will likely never match the `test` rule (.ts files) so this exclude is not useful.
Contributor
ghost
marked this pull request as ready for review
November 16, 2021 13:49
ghost
self-requested a review
as a code owner
November 16, 2021 13:49
maxjeffos
approved these changes
Nov 17, 2021
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When providing strings, Webpack matches absolute paths so the current
'/node_modules'rule excludes nothing.https://webpack.js.org/configuration/module/#condition
Fixing this by using a regex
/node_modules/does not improve build performance at all since imports via node_modules will likely never match thetestrule (.ts files) so this exclude is not useful.