Skip to content

refactor: remove isRequired check - #2371

Merged
1 commit merged into
masterfrom
refactor/remove-isrequired
Nov 18, 2021
Merged

refactor: remove isRequired check#2371
1 commit merged into
masterfrom
refactor/remove-isrequired

Conversation

@ghost

@ghost ghost commented Nov 16, 2021

Copy link
Copy Markdown

Seems this was used at some point when Snyk CLI was used via imports.

We now only support Snyk CLI as an executable via bin/snyk so this shouldn't be needed.

Seems this was used at some point when Snyk CLI was used via imports.

We now only support it as an executable via bin/snyk so this shouldn't be needed.
@github-actions

Copy link
Copy Markdown
Contributor
Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • src/lib/spinner.ts
⚠️ You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?
Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against 7cd335a

@ghost
ghost marked this pull request as ready for review November 16, 2021 15:57
@ghost
ghost requested review from a team as code owners November 16, 2021 15:57
@ghost
ghost merged commit 3e1a5be into master Nov 18, 2021
@ghost
ghost deleted the refactor/remove-isrequired branch November 18, 2021 17:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant