fix: Add container detection for other container runtimes - #5835
Closed
DominicLavery wants to merge 1 commit into
Closed
fix: Add container detection for other container runtimes#5835DominicLavery wants to merge 1 commit into
DominicLavery wants to merge 1 commit into
Conversation
DominicLavery
force-pushed
the
add-alternative-runtimes-support
branch
from
April 15, 2025 11:19
265ef09 to
6af438d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
This PR enables the container detection to work in container runtimes other than docker such as Podman and cri-o by checking for an additional file
/run/.containerenv. This is a low risk change as it follows an established pattern in the codebase and has minimal changes.Where should the reviewer start?
src/lib/is-docker.ts
How should this be manually tested?
Run the
regression-teststests inside a podman containerWhat's the product update that needs to be communicated to CLI users?
The CLI should no longer try and open a browser automatically when run in container environments other than dockers
Any background context you want to provide?
This relates to support request #159183 with CircleCI and should resolve issues running tests on the new container runtime.