fix: [OSM-2584] Bump PHP plugin version to fix project scanning - #5869
Merged
Conversation
nico-incubiq
force-pushed
the
fix/osm-2584-php-support
branch
2 times, most recently
from
May 2, 2025 11:46
eeddce5 to
ea98589
Compare
nico-incubiq
enabled auto-merge
May 2, 2025 13:33
Contributor
|
@nico-incubiq based on the description it appears to me that we don't have any relevant php related test here. Could you please take a look in |
Contributor
Author
|
@PeterSchafer interesting point; there is already an acceptance test for this, but it was exercising an overly permissive code path which was hiding the issue (interpreting the error as if we found a |
PeterSchafer
approved these changes
May 6, 2025
nico-incubiq
force-pushed
the
fix/osm-2584-php-support
branch
from
May 6, 2025 15:55
ea98589 to
39e3379
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
Bumps the version of the PHP Plugin used by the CLI, which fixes Open Source scanning of PHP projects.
Previously when
composer/composer.pharis available on the machine, the command's resultstdoutwas not handled properly and resulted in[object Object]being parsed as JSON.Risk is Low as this only affects PHP, which has low traffic and it fixes a bug rather than changing any logic.
Where should the reviewer start?
How should this be manually tested?
composer.pharfile in the current working directory.What's the product update that needs to be communicated to CLI users?
Scanning open source dependencies of PHP projects when composer is installed on the user machine works again.