Skip to content

fix(code): Fix hash mismatch errors when uploading non UTF-8 content - #5874

Merged
PeterSchafer merged 1 commit into
mainfrom
fix/CLI-871_hash_mismatch
May 5, 2025
Merged

fix(code): Fix hash mismatch errors when uploading non UTF-8 content#5874
PeterSchafer merged 1 commit into
mainfrom
fix/CLI-871_hash_mismatch

Conversation

@PeterSchafer

@PeterSchafer PeterSchafer commented May 2, 2025

Copy link
Copy Markdown
Contributor

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

This PR adds a fix for hash mismatch errors in the golang native code test implementation. The issue occurs if non UTF-8 content is being uploaded. The test is adapted to use a random binary file to cover this special case.

Where should the reviewer start?

snyk/code-client-go#96

How should this be manually tested?

Run either of the User Journey tests with a version from the branch and with another unpatched version.

What's the product update that needs to be communicated to CLI users?

In the golang native code test implementation (CCI) fix hash mismatch errors when uploading non UTF-8 content.

@PeterSchafer
PeterSchafer requested a review from a team as a code owner May 2, 2025 17:25
@github-actions

github-actions Bot commented May 2, 2025

Copy link
Copy Markdown
Contributor
Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • test/jest/acceptance/snyk-code/snyk-code-user-journey.spec.ts

Generated by 🚫 dangerJS against 33d33e9

@CatalinSnyk
CatalinSnyk force-pushed the fix/CLI-871_hash_mismatch branch from cc9a511 to 33d33e9 Compare May 5, 2025 09:24
@PeterSchafer
PeterSchafer enabled auto-merge May 5, 2025 09:59
@PeterSchafer
PeterSchafer merged commit 1022e03 into main May 5, 2025
@PeterSchafer
PeterSchafer deleted the fix/CLI-871_hash_mismatch branch May 5, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants