fix(code): Fix hash mismatch errors when uploading non UTF-8 content - #5874
Merged
Conversation
Contributor
|
CatalinSnyk
force-pushed
the
fix/CLI-871_hash_mismatch
branch
from
May 5, 2025 09:24
cc9a511 to
33d33e9
Compare
CatalinSnyk
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
This PR adds a fix for hash mismatch errors in the golang native code test implementation. The issue occurs if non UTF-8 content is being uploaded. The test is adapted to use a random binary file to cover this special case.
Where should the reviewer start?
snyk/code-client-go#96
How should this be manually tested?
Run either of the User Journey tests with a version from the branch and with another unpatched version.
What's the product update that needs to be communicated to CLI users?
In the golang native code test implementation (CCI) fix hash mismatch errors when uploading non UTF-8 content.