test: add acceptance tests for IaCV2 [IAC-3297] - #5875
Merged
Conversation
ioannacaba
force-pushed
the
feat/IAC-3297/add-acceptance-tests-for-iacv2
branch
from
May 5, 2025 10:29
aacb067 to
c9ccca6
Compare
Contributor
|
@ioannacaba Just putting this out there, but I think you can get the secret secret scan to pass by squashing the commits into one. Let me know if you need help 😄 |
ioannacaba
force-pushed
the
feat/IAC-3297/add-acceptance-tests-for-iacv2
branch
7 times, most recently
from
May 8, 2025 06:55
71d4196 to
f9b6104
Compare
ioannacaba
marked this pull request as ready for review
May 8, 2025 07:30
ioannacaba
force-pushed
the
feat/IAC-3297/add-acceptance-tests-for-iacv2
branch
2 times, most recently
from
May 8, 2025 08:26
f9e8d68 to
de3c633
Compare
j-luong
requested changes
May 8, 2025
j-luong
left a comment
Contributor
There was a problem hiding this comment.
update the commit message from fix: add acceptance tests for IaCV2 [IAC-3297]
to test: add acceptance tests for IaCV2 [IAC-3297] or chore: add acceptance tests for IaCV2 [IAC-3297]
to avoid any versioning issues
ioannacaba
force-pushed
the
feat/IAC-3297/add-acceptance-tests-for-iacv2
branch
2 times, most recently
from
May 8, 2025 13:51
04a7e21 to
059178f
Compare
ioannacaba
force-pushed
the
feat/IAC-3297/add-acceptance-tests-for-iacv2
branch
from
May 13, 2025 07:59
059178f to
1e7a9c0
Compare
j-luong
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
Adds acceptance tests for
IaCV2. We need acceptance test for IaCV2 to verify that a new change made in the CLI does not affect IaC scans for IaCV2.The new acceptance tests cover a range of scenarios, including:
file-output.spec.ts).test-directory.spec.ts).org-flag.spec.ts).And the folowing tests validating scans for multiple IaC types (like
arm,cloudformation,terraform,terraform-plan,kubernetes):multidoc-yaml.spec.tstest-arm.spec.tstest-cloudformation.spec.tstest-kubernetes.spec.tstest-terraform-plan.spec.tsThese tests validate behavior with different output formats (
--json,--sarif), severity threshold filtering (--severity-threshold), scan depth control (--detection-depth), and multi-path scanning. All the tests enable theiacNewEngineFF before execution.Where should the reviewer start?
All the tests were added in the
test/jest/acceptance/iacdirectory.How should this be manually tested?
Just by running in the CLI the command:
npm run test:acceptance.What's the product update that needs to be communicated to CLI users?
No product update.