fix: add container test target reference support [CN-71] - #5881
Merged
aarlaud merged 3 commits intoMay 12, 2025
Merged
Conversation
aarlaud
force-pushed
the
fix/CN-71-add-target-reference-support-for-cli-snyk-container-test
branch
3 times, most recently
from
May 9, 2025 15:07
670afb1 to
c1e12d8
Compare
aarlaud
marked this pull request as ready for review
May 9, 2025 15:08
aarlaud
force-pushed
the
fix/CN-71-add-target-reference-support-for-cli-snyk-container-test
branch
from
May 9, 2025 20:28
0a288c0 to
5102bf4
Compare
chore: fix test and add target ref in cli cmds docs fix: pin particular docker plugin version
aarlaud
force-pushed
the
fix/CN-71-add-target-reference-support-for-cli-snyk-container-test
branch
from
May 12, 2025 10:08
a8659d9 to
61b391b
Compare
Contributor
|
added 2 commits
May 12, 2025 17:21
danlucian
approved these changes
May 12, 2025
aarlaud
enabled auto-merge
May 12, 2025 16:00
aarlaud
deleted the
fix/CN-71-add-target-reference-support-for-cli-snyk-container-test
branch
May 12, 2025 19:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
Adds test cases for the target ref support in container monitor and test, following support addition in the snyk-docker-plugin snyk/snyk-docker-plugin#649.
Where should the reviewer start?
This change mainly bumps the docker plugin to 7.0.1 and add tests for the newly added target reference support in snyk container test.
How should this be manually tested?
Running
snyk container test <IMAGE> --target-reference=<VALUE>should send a payload containing the target reference in the scanResult object sent to /test-dependencies endpoint.What's the product update that needs to be communicated to CLI users?
The product update is deferred to a later time. This change currently requires a FF in the platform to be effective.
While the plan is for a wider rollout, we're taking extra precautions to validate that no one is relying on the "erroneous" behavior.
Behavior that could cause a change is a particular combination of circumstances:
We're extracting data to confirm no one fit this particular scenario and will reach out to individual cases if any to notify them of the upcoming change.
What are the relevant tickets?
https://snyksec.atlassian.net/browse/CN-71