Skip to content

fix: [OSM-2662] maven dverbose show resolved deps versions only - #5894

Merged
gemaxim merged 1 commit into
mainfrom
fix/OSM-2662/maven-dverbose-include-only-resolved-versions
May 19, 2025
Merged

fix: [OSM-2662] maven dverbose show resolved deps versions only#5894
gemaxim merged 1 commit into
mainfrom
fix/OSM-2662/maven-dverbose-include-only-resolved-versions

Conversation

@gemaxim

@gemaxim gemaxim commented May 16, 2025

Copy link
Copy Markdown
Contributor

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

Follow-up from #5891: keep only the versions resolved by maven in the Dverbose algorithm.
Tests are reverted to the values before this PR: the dependency that actually gets resolved by maven (not considered, but omitted) is at version 1.0.3. Same thing for the length of the dependencies array.

Where should the reviewer start?

This is introduced: snyk/snyk-mvn-plugin#190, see tests.

How should this be manually tested?

snyk test/monitor -- -Dverbose or snyk sbom on the fixtures projects.

What's the product update that needs to be communicated to CLI users?

[test, monitor, sbom] Maven Dverbose algorithm adds only the dependencies resolved by maven in the dependency graph/sbom.

What are the relevant tickets?

https://snyksec.atlassian.net/browse/OSM-2668

@gemaxim
gemaxim force-pushed the fix/OSM-2662/maven-dverbose-include-only-resolved-versions branch from f50fb86 to 8b86b8e Compare May 16, 2025 08:28
@gemaxim gemaxim self-assigned this May 16, 2025
@gemaxim
gemaxim marked this pull request as ready for review May 16, 2025 08:34
@gemaxim
gemaxim requested a review from a team as a code owner May 16, 2025 08:34
@gemaxim
gemaxim force-pushed the fix/OSM-2662/maven-dverbose-include-only-resolved-versions branch from 8b86b8e to 9b6abd3 Compare May 16, 2025 12:25
@gemaxim
gemaxim merged commit 16ca6d1 into main May 19, 2025
@gemaxim
gemaxim deleted the fix/OSM-2662/maven-dverbose-include-only-resolved-versions branch May 19, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants