fix: [OSM-2662] maven dverbose show resolved deps versions only - #5894
Merged
gemaxim merged 1 commit intoMay 19, 2025
Merged
Conversation
gemaxim
force-pushed
the
fix/OSM-2662/maven-dverbose-include-only-resolved-versions
branch
from
May 16, 2025 08:28
f50fb86 to
8b86b8e
Compare
gemaxim
marked this pull request as ready for review
May 16, 2025 08:34
gemaxim
force-pushed
the
fix/OSM-2662/maven-dverbose-include-only-resolved-versions
branch
from
May 16, 2025 12:25
8b86b8e to
9b6abd3
Compare
CatalinSnyk
approved these changes
May 16, 2025
gemaxim
deleted the
fix/OSM-2662/maven-dverbose-include-only-resolved-versions
branch
May 19, 2025 04:53
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
Follow-up from #5891: keep only the versions resolved by maven in the Dverbose algorithm.
Tests are reverted to the values before this PR: the dependency that actually gets resolved by maven (not considered, but omitted) is at version 1.0.3. Same thing for the length of the dependencies array.
Where should the reviewer start?
This is introduced: snyk/snyk-mvn-plugin#190, see tests.
How should this be manually tested?
snyk test/monitor -- -Dverboseorsnyk sbomon the fixtures projects.What's the product update that needs to be communicated to CLI users?
[test, monitor, sbom] Maven Dverbose algorithm adds only the dependencies resolved by maven in the dependency graph/sbom.
What are the relevant tickets?
https://snyksec.atlassian.net/browse/OSM-2668