chore: adding a central check for the experimental flag - #6056
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
66a1a34 to
0fa86c0
Compare
0fa86c0 to
8b74482
Compare
8b74482 to
b8cf2a6
Compare
There was a problem hiding this comment.
Bug: Connectivity Check Workflow Visibility Issue
The removal of the initConnectivityCheck wrapper function, replaced by a direct call to workflows.InitConnectivityCheckWorkflow, eliminates the explicit SetVisibility(true) call for the "tools.connectivity-check" workflow. Consequently, the snyk tools connectivity-check command becomes hidden and inaccessible, preventing its use even with the --experimental flag, as the centralized experimental flag check cannot operate on an invisible workflow.
cliv2/cmd/cliv2/main.go#L562-L563
Lines 562 to 563 in b8cf2a6
Was this report helpful? Give feedback by reacting with 👍 or 👎
This is just not correct. Sorry. Workflows are visible by default! |
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
This PR is based on newly introduced helper functions to ensure experimental workflows are handled consistently.
It also moves the responsibility to raise an error from the workflows themselves to the application layer, which is more correct from the perspective of concerns as an error might not be the correct behaviour for every application.
Some existing tests had to be adapted to not expected an explicit text but rather ensure that the cli fails.
Where should the reviewer start?
snyk/go-application-framework#386
How should this be manually tested?
Running the following commands should behave the same and show the following error
Errors (SNYK-CLI-0015)
No or other Errors
What's the product update that needs to be communicated to CLI users?