fix: ignoring windows signing operations on feature branches (non-e2e test) - #6131
Closed
dotkas wants to merge 1 commit into
Closed
fix: ignoring windows signing operations on feature branches (non-e2e test)#6131dotkas wants to merge 1 commit into
dotkas wants to merge 1 commit into
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
dotkas
commented
Aug 26, 2025
| install_path: 'C:\' | ||
| executor: win-server2022-amd64 | ||
| context: | ||
| - snyk-windows-signing |
Contributor
Author
There was a problem hiding this comment.
If credentials are not available, we just skip the signing part and continue:
cli/cliv2/scripts/sign_windows.ps1
Lines 18 to 22 in c17867b
dotkas
force-pushed
the
dotkas/skip-windows-signing-on-feature-branches
branch
from
August 26, 2025 08:48
5b8634f to
58a7d5a
Compare
dotkas
commented
Aug 26, 2025
Comment on lines
-244
to
-248
| install-deps-windows-full-signing: | ||
| steps: | ||
| - install-deps-windows-signing | ||
| - install-deps-windows-make | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Both steps gets called during windows-make in
Lines 723 to 738 in 58a7d5a
dotkas
marked this pull request as ready for review
August 26, 2025 09:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
Stops the digicert signing process on non-feature branches by simply removing the context containing credentials.
Where should the reviewer start?
The CircleCI pipeline file as well as my comments try to elaborate. A full end-to-end version has been created to prove no regressions: #6132
How should this be manually tested?
N/A, see e2e runs.
What's the product update that needs to be communicated to CLI users?
N/A, pipeline optimization.