Skip to content

fix: ignoring windows signing operations on feature branches (non-e2e test) - #6131

Closed
dotkas wants to merge 1 commit into
mainfrom
dotkas/skip-windows-signing-on-feature-branches
Closed

fix: ignoring windows signing operations on feature branches (non-e2e test)#6131
dotkas wants to merge 1 commit into
mainfrom
dotkas/skip-windows-signing-on-feature-branches

Conversation

@dotkas

@dotkas dotkas commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Commit messages
    are release-note ready, emphasizing
    what was changed, not how.
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

Stops the digicert signing process on non-feature branches by simply removing the context containing credentials.

Where should the reviewer start?

The CircleCI pipeline file as well as my comments try to elaborate. A full end-to-end version has been created to prove no regressions: #6132

How should this be manually tested?

N/A, see e2e runs.

What's the product update that needs to be communicated to CLI users?

N/A, pipeline optimization.

@snyk-io

snyk-io Bot commented Aug 26, 2025

Copy link
Copy Markdown

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

Comment thread .circleci/config.yml
install_path: 'C:\'
executor: win-server2022-amd64
context:
- snyk-windows-signing

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If credentials are not available, we just skip the signing part and continue:

# if the required secrets are not available we skip signing completely without an error to enable local builds on windows. A later issigned check will catch this error in the build pipeline
if (-Not (Test-Path env:SM_CODE_SIGNING_CERT_SHA1_HASH)) {
Write-Host "$LOG_PREFIX Skipping signing, since the required secrets are not available."
exit
}

@dotkas dotkas changed the title fix: ignoring windows signing operations on non-e2e branches fix: ignoring windows signing operations on feature branches (non-e2e test) Aug 26, 2025
@dotkas
dotkas force-pushed the dotkas/skip-windows-signing-on-feature-branches branch from 5b8634f to 58a7d5a Compare August 26, 2025 08:48
Comment thread .circleci/config.yml
Comment on lines -244 to -248
install-deps-windows-full-signing:
steps:
- install-deps-windows-signing
- install-deps-windows-make

@dotkas dotkas Aug 26, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both steps gets called during windows-make in

cli/.circleci/config.yml

Lines 723 to 738 in 58a7d5a

- sign:
name: sign windows amd64
context: snyk-windows-signing
requires:
- build windows amd64
go_os: windows
go_arch: amd64
make_target: sign sign-fips
executor: win-server2022-amd64
install_deps_extension: windows-make
filters:
branches:
only:
- main
- '/release.*/'
- '/.*e2e.*/'

@dotkas
dotkas marked this pull request as ready for review August 26, 2025 09:34
@dotkas
dotkas requested review from a team as code owners August 26, 2025 09:34
Comment thread .circleci/config.yml
@dotkas dotkas closed this Aug 26, 2025
@dotkas
dotkas deleted the dotkas/skip-windows-signing-on-feature-branches branch September 4, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant