chore: Reduce Windows CI build time#6987
Open
danskmt wants to merge 1 commit into
Open
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
9 tasks
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
Reduces Windows CI build time. On main, the Windows build job installs the full toolchain (Node, Maven, Gradle, .NET, Python, Make) plus DigiCert signing tools, even though compiling only needs Node/Python/Make — and its Go module cache uses a Linux-only path that never hits on Windows, so modules re-download every run.
This PR:
windows-native-build-mindeps bundle (Node, Python, Make) with its own small cache for the build job. .NET/Maven/Gradle stay only on the acceptance-test job that needs them.sign windows amd64.clean-golang, and adds averify-fips-artifactsstep that fails if the FIPS build did not take effect.Where should the reviewer start?
.circleci/config.yml—install-deps-windows-native-build-min,setup-go-build-cache, thebuild windows amd64job, and thebuild-artifactGo cachescripts/verify-fips-build.shandMakefile(verify-fips-artifacts) — the FIPS safety netscripts/windows/*.ps1— skip-if-already-installed logicHow should this be manually tested?
test_and_releasein CircleCI.build windows amd64restores the small build cache (not the ~3.6 GiB one) and does not install .NET/Maven/Gradle/DigiCert.verify-fips-artifactsstep passes and logs distinct sha256 hashes for the normal vs FIPS binaries.acceptance-tests windows amd64still passes (full tool bundle).main/release/*e2e*branch, confirmsign windows amd64and thee2e fips tests (win-server2022-amd64)still pass.What's the product update that needs to be communicated to CLI users?
None. CI-only change with no user-facing impact.
Risk assessment (Low | Medium | High)?
Low-Medium. CI-only, no user-facing changes. The main correctness concern — removing
clean-golangwhile building normal + FIPS in one job — is guarded byverify-fips-artifacts, which fails the build if the FIPS binary is not distinct from the normal one. FIPS runtime behaviour is still covered by the existinge2e fips testsjob.Any background context you want to provide?
The Windows build was dominated by cache/dependency overhead rather than compilation: a multi-GB tool cache (mostly .NET/Gradle unused by the build), duplicated DigiCert installs, and a Go module cache that never hit on Windows. These changes remove that overhead from the build path while keeping the tools available where they are actually used (tests/signing).
What are the relevant tickets?
CLI-1633
Screenshots (if appropriate)
N/A