You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Includes product update to be announced in the next stable release notes
What does this PR do?
Ensures the prepare-build job's Set version step always uses private build mode for version generation. Flaky auto-detection of private module access in CI could produce public versions with the .oss suffix, inconsistent with the private builds used elsewhere in test_and_release.
Where should the reviewer start?
.circleci/config.yml — prepare-build job, Set version step
How should this be manually tested?
Confirm the prepare-build job passes in CircleCI.
In the Set version step logs, confirm Build mode: private and that the generated version does not include an .oss suffix.
What's the product update that needs to be communicated to CLI users?
None. Internal CI change only.
Risk assessment (Low | Medium | High)?
Low
Any background context you want to provide?
Similar to #52987e419, which enforced private build mode on build-artifact jobs. Auto-detection via go mod download against cliv2-private can intermittently fail in CI, causing next-version.sh to run in public mode and append .oss to dev versions.
The command 'make release-validate-version' on line 1527 is not updated to include 'BUILD_MODE=private'. While the surrounding make commands on lines 1526 and 1528 correctly force private mode, this intermediate validation step still relies on the auto-detection logic that the PR description characterizes as flaky. If this detection incorrectly identifies the build as 'public', the validation will fail because it will look for an '.oss' suffix that was explicitly omitted by the preceding forced-private generation step on line 1526. To ensure the fix is robust, the flag should be passed to all make invocations in this block or set as an environment variable for the entire step.
make binary-releases/version binary-releases/fips/version BUILD_MODE=privatemake release-validate-versionmake ts-cli-binaries/version BINARY_RELEASES_FOLDER_TS_CLI=ts-cli-binaries BUILD_MODE=private
📚 Repository Context Analyzed
This review considered 4 relevant code sections from 2 files (average relevance: 0.75)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
Ensures the
prepare-buildjob's Set version step always uses private build mode for version generation. Flaky auto-detection of private module access in CI could produce public versions with the.osssuffix, inconsistent with the private builds used elsewhere intest_and_release.Where should the reviewer start?
.circleci/config.yml—prepare-buildjob, Set version stepHow should this be manually tested?
prepare-buildjob passes in CircleCI.Build mode: privateand that the generated version does not include an.osssuffix.What's the product update that needs to be communicated to CLI users?
None. Internal CI change only.
Risk assessment (Low | Medium | High)?
Low
Any background context you want to provide?
Similar to #52987e419, which enforced private build mode on build-artifact jobs. Auto-detection via
go mod downloadagainstcliv2-privatecan intermittently fail in CI, causingnext-version.shto run in public mode and append.ossto dev versions.What are the relevant tickets?
CLI-1686
Screenshots (if appropriate)
N/A