test: isolate CLI-1765 Go fix from the snyk-docker-plugin bump - #7131
Closed
bdemeo12 wants to merge 3 commits into
Closed
test: isolate CLI-1765 Go fix from the snyk-docker-plugin bump#7131bdemeo12 wants to merge 3 commits into
bdemeo12 wants to merge 3 commits into
Conversation
…-1765] `processError` combines the command exit error with collected network errors via `errors.Join`, both in `FindMostRelevantError` and `createErrorWithExitCode`. A joined error does not satisfy the direct type assertions in `displayError`, so handled auxiliary errors were printed after valid command output - emitting a second JSON object and breaking `JSON.parse(stdout)`. Decide displayability at the top of `processError`, while the concrete error type is still intact, and pass that decision through to teardown. The combined error is still used for exit-code derivation and analytics, so both are unchanged. Also pins snyk-docker-plugin to 9.20.0 so CI exercises the failure this fixes: 9.20.0 performs a best-effort provenance fetch whose handled failure is what triggered the duplicate output (see CLIA-1576). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
FindMostRelevantError returns promoted errors (e.g. maintenance windows) uncombined, so judge those on their own merits rather than on the original error. Without this, a maintenance notice was suppressed whenever the command also exited non-zero. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Same Go change as CLI-1765/prevent-duplicate-error-output, but with snyk-docker-plugin back at 9.16.0. If the acceptance tests pass here, the 9.20.0 bump caused the failures, not the error-handling change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
|
Contributor
Author
|
Answered its question: the failures came from the Go change, not the dependency bump. Superseded by the reworked fix in #7130. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway branch to isolate a variable — not for review.
Identical Go change to #7130, but
snyk-docker-pluginstays at 9.16.0.#7130 failed acceptance tests on all 8 platforms (auth errors printing nothing). That PR changes two things at once: the error-handling fix and the 9.16.0 → 9.20.0 bump. This separates them.
Will be closed once it has answered the question.