fix: Allow package.json to have missing dependency property - #23
Merged
Conversation
|
|
Contributor
|
Can you also add a test case where the |
Contributor
Author
|
@adrukh That is exactly what this test is, it re-uses a fixture we already have which only has |
|
🎉 This PR is included in version 1.5.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
michael-go
added a commit
to snyk/cli
that referenced
this pull request
Oct 12, 2018
nodejs-lockfile-parser PR: snyk/nodejs-lockfile-parser#23
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Even though
dependenciesis a required field for npm,npm initdoesn't seem to generate this property and users can easily not add thedependenciesto the file. Return empty tree if this happens and do not error.Notes for the reviewer
Instructions on how to run this locally, background context, what to review, questions…
More information