Adds SocketIOClient#once(event, callback) #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the specified event is emitted, the handler deregisters itself.
Member
There was a problem hiding this comment.
You shouldn't need type declarations here.
let handler = SocketEventHandler(event: event) {data, ack inShould be fine
Contributor
Author
|
All fixed! 👍 |
Contributor
Author
There was a problem hiding this comment.
You can't compare structs. I looked at other Swift-based event dispatchers that support removing specific handlers and they use id's like this to compare them.
nuclearace
added a commit
that referenced
this pull request
Sep 18, 2015
Adds SocketIOClient#once(event, callback)
Contributor
|
It would be great to cover this functions with tests... In my opinion every new functions should be tested, before the PR is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the specified event is emitted, the handler deregisters itself.