Skip to content

Adds SocketIOClient#once(event, callback) #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 18, 2015
Merged

Adds SocketIOClient#once(event, callback) #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a72f967
Adds SocketIOClient#once(event, callback)
kevinmartin Sep 17, 2015
9b3f84d
Remove type declarations
kevinmartin Sep 18, 2015
136847f
Fix "Variable used within its own initial value" error
kevinmartin Sep 18, 2015
7d26bd3
Fix type declarations
kevinmartin Sep 18, 2015
f5c3a2c
Add strict equality and execute "callback" as non-optional
kevinmartin Sep 18, 2015
fe8469c
Add SocketEventHandler#id to filter against
kevinmartin Sep 18, 2015
aaaf9dc
Filter against SocketEventHandler#id
kevinmartin Sep 18, 2015
a9b4193
Fix "Variable 'handler' captured by a closure before being initialize…
kevinmartin Sep 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions SocketIOClientSwift/SocketEventHandler.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ private func emitAckCallbackObjectiveC(socket: SocketIOClient?, num: Int?)
}

struct SocketEventHandler {
let id = NSUUID()
Copy link
Member

@nuclearace nuclearace Sep 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Contributor Author

@kevinmartin kevinmartin Sep 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't compare structs. I looked at other Swift-based event dispatchers that support removing specific handlers and they use id's like this to compare them.

let event: String
let callback: NormalCallback?
let callBackObjectiveC: NormalCallbackObjectiveC?
Expand Down
32 changes: 32 additions & 0 deletions SocketIOClientSwift/SocketIOClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,38 @@ public final class SocketIOClient: NSObject, SocketEngineClient {
handlers.append(handler)
}

/**
Adds a single-use handler for an event.
*/
public func once(event: String, callback: NormalCallback) {
Logger.log("Adding once handler for event: %@", type: logType, args: event)

var handler: SocketEventHandler?;

handler = SocketEventHandler(event: event) { (data, ack: AckEmitter?) in
self.handlers = ContiguousArray(self.handlers.filter { $0.id != handler!.id })
callback(data, ack)
}

handlers.append(handler!)
}

/**
Adds a single-use handler for an event.
*/
public func once(event event: String, callback: NormalCallbackObjectiveC) {
Logger.log("Adding once handler for event: %@", type: logType, args: event)

var handler: SocketEventHandler?;

handler = SocketEventHandler(event: event) { (data, ack: AckEmitterObjectiveC?) in
self.handlers = ContiguousArray(self.handlers.filter { $0.id != handler!.id })
callback(data, ack)
}

handlers.append(handler!)
}

/**
Removes all handlers.
Can be used after disconnecting to break any potential remaining retain cycles.
Expand Down