Skip to content

Expose HTTP protocol names#228

Merged
samuel-williams-shopify merged 2 commits into
mainfrom
expose-http-protocol-names
Jul 23, 2026
Merged

Expose HTTP protocol names#228
samuel-williams-shopify merged 2 commits into
mainfrom
expose-http-protocol-names

Conversation

@samuel-williams-shopify

Copy link
Copy Markdown
Contributor

Summary

  • Expose the complete set of protocol names supported by the plaintext HTTP negotiator.
  • Preserve the configured HTTP/2-then-HTTP/1 preference order while removing duplicate names.
  • Cover both the default negotiator and a restricted protocol configuration.

This makes Async::HTTP::Protocol::HTTP.names consistent with the existing HTTPS.names interface and allows integrations to serialize protocol capabilities without depending on Async::HTTP implementation constants.

Testing

  • bundle exec sus test/async/http/protocol/http.rb (7 tests, 9 assertions)
  • bundle exec bake test (229 passed, 3 skipped, 33,904 assertions)
  • bundle exec rubocop
  • bundle exec bake decode:index:coverage lib (292/292 definitions)

@samuel-williams-shopify
samuel-williams-shopify merged commit d21ded2 into main Jul 23, 2026
34 of 40 checks passed
@samuel-williams-shopify
samuel-williams-shopify deleted the expose-http-protocol-names branch July 23, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant