Add graceful default signal handlers#4
Merged
Conversation
2f8912c to
d06263c
Compare
Contributor
Author
|
I dislike this approach. |
89a278f to
2619a35
Compare
2619a35 to
181b148
Compare
Contributor
Author
|
This is the lesser of two slightly problematic approaches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
async/signals/graceful, which immediately installs defaultSIGINTandSIGTERMhandlers that raiseInterruptonThread.main. Existing non-default traps are preserved.This provides a shared graceful shutdown policy for libraries like Async and Async::Container without each caller needing to install its own process signal traps.
Validation
bundle exec rubocop -Abundle exec sus test/async/signals/graceful.rb --verbosebundle exec bake decode:index:coverage libCOVERAGE=PartialSummary bundle exec susbundle exec bake covered:validate --paths .covered.db