Skip to content

Simplify message compression - #7

Merged
samuel-williams-shopify merged 1 commit into
mainfrom
simplify/readable-decompression
Aug 13, 2026
Merged

Simplify message compression#7
samuel-williams-shopify merged 1 commit into
mainfrom
simplify/readable-decompression

Conversation

@samuel-williams-shopify

@samuel-williams-shopify samuel-williams-shopify commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • use zlib one-shot helpers for gzip and deflate compression and decompression
  • keep error translation scoped to each individual zlib operation
  • preserve UNIMPLEMENTED for unsupported inbound compression encodings
  • cover successful and failing gzip and deflate operations independently

Verification

  • COVERAGE=PartialSummary bundle exec bake test — 228 tests, 405 assertions, 482/482 lines (100.0%)
  • bundle exec bake covered:validate --paths .covered.db \;
  • bundle exec rubocop

@samuel-williams-shopify
samuel-williams-shopify force-pushed the simplify/readable-decompression branch from ab0d523 to 88ebe8b Compare August 13, 2026 09:15
@samuel-williams-shopify samuel-williams-shopify changed the title Simplify message decompression Simplify message compression Aug 13, 2026
Assisted-By: devx/48bd9802-2aca-41ba-856d-0b5bd523f9cf
@samuel-williams-shopify
samuel-williams-shopify force-pushed the simplify/readable-decompression branch from 88ebe8b to a5044e8 Compare August 13, 2026 09:23
@samuel-williams-shopify
samuel-williams-shopify merged commit 852343d into main Aug 13, 2026
40 checks passed
@samuel-williams-shopify
samuel-williams-shopify deleted the simplify/readable-decompression branch August 13, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant