Encapsulate lazy session persistence. - #93
Merged
Conversation
Assisted-By: devx/cbdeae41-9308-4071-ad53-58cd92db2946
samuel-williams-shopify
force-pushed
the
encapsulate-session-values
branch
from
August 17, 2026 07:19
cfed490 to
27f213f
Compare
samuel-williams-shopify
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove public access to the mutable hash underlying
Utopia::Session::LazyHash.Make
load!private and replace the rawvaluesaccessor with an explicitpersistlifecycle. Persistence now checks whether an update is required, updatesupdated_at, yields the internal values for immediate serialization, and only clears the changed state after successful persistence.This avoids copying the session hash while preventing accidental mutation through general-purpose accessors. Tests cover successful persistence, failed persistence, timestamp updates, and accessor visibility.